Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nav link to /classify-systems #2128

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jan 4, 2023

Closes https://github.com/ethyca/fidesplus/issues/473

This PR needs two changes since it affects the nav bar which is used both in admin-ui and datamap-ui. The datamap-ui PR is here

Code Changes

  • Adds nav link for /classify-systems if plus backend

Steps to Confirm

  • Start up the plus backend via make server
  • Click on "Add systems" in the home page. You should see "Classify systems" in the side nav menu

Clicking on "Data Map" to get to "Classify systems" won't work until https://github.com/ethyca/fidesplus/pull/496 is merged and you also have the datamap UI running

Pre-Merge Checklist

Description Of Changes

Screen.Recording.2023-01-04.at.11.36.15.AM.mov

@allisonking allisonking marked this pull request as ready for review January 4, 2023 17:48
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allisonking allisonking merged commit c5654cd into main Jan 6, 2023
@allisonking allisonking deleted the aking/fidesplus-473/nav-classify-systems branch January 6, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants